Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update peerDependency #3318

Closed
wants to merge 2 commits into from
Closed

update peerDependency #3318

wants to merge 2 commits into from

Conversation

sixmen
Copy link
Member

@sixmen sixmen commented Mar 30, 2018

Issue:

What I did

remove npm WARNs

$ npm install    
npm WARN @storybook/addon-actions@4.0.0-alpha.1 requires a peer of @storybook/addons@^3.3.0 but none is installed. You must install peer dependencies yourself.
npm WARN @storybook/addon-notes@4.0.0-alpha.1 requires a peer of @storybook/addons@^3.3.0 but none is installed. You must install peer dependencies yourself.
npm WARN @storybook/addon-options@4.0.0-alpha.1 requires a peer of @storybook/addons@^3.3.0 but none is installed. You must install peer dependencies yourself.

How to test

Is this testable with Jest or Chromatic screenshots? NO

Does this need a new example in the kitchen sink apps? NO

Does this need an update to the documentation? NO

If your answer is yes to any of these, please make sure to include it in your PR.

@storybook-safe-bot
Copy link
Contributor

storybook-safe-bot commented Mar 30, 2018 •
edited
Loading

Fails
🚫

PR is marked with "do not merge" label.

Generated by 🚫 dangerJS

@sixmen
Copy link
Member Author

sixmen commented Mar 30, 2018

I found 9f3abba after make this PR.

Please close this PR if not appropriate.

@Hypnosphi
Copy link
Member

I think we can put * there

@sixmen
Copy link
Member Author

sixmen commented Mar 31, 2018

I read lerna/lerna#1018 again.
It says lerna publish update peerDependencies too.
I think it is better to install same versions for Storybook, so it is not a problem to update peerDependencies.

But if you think it is a problem, how about "^4.0" or "^3.4 || ^4.0" or "^3.3 || ^3.4 || ^4.0" instead of "*"

@Hypnosphi
Copy link
Member

Hypnosphi commented Mar 31, 2018 •
edited
Loading

>= 3.3.0 || ^4.0.0-alpha.0 should work as stable 3.4.0 is now published

@codecov
Copy link

codecov bot commented Apr 3, 2018

Codecov Report

Merging #3318 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3318      +/-   ##
==========================================
- Coverage   35.82%   35.63%   -0.19%     
==========================================
  Files         472      472              
  Lines       10164    10121      -43     
  Branches      979      935      -44     
==========================================
- Hits         3641     3607      -34     
- Misses       5887     5933      +46     
+ Partials      636      581      -55
Impacted Files Coverage Δ
app/mithril/src/server/utils.js 0% <0%> (-100%) ⬇️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (-6.96%) ⬇️
addons/knobs/src/react/WrapStory.js 49.42% <0%> (-6.7%) ⬇️
lib/components/src/navigation/routed_link.js 94.54% <0%> (-5.46%) ⬇️
addons/background/src/index.js 80% <0%> (-3.34%) ⬇️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (-3.23%) ⬇️
...ui/src/modules/ui/components/search_box.stories.js 57.14% <0%> (-2.86%) ⬇️
.../ui/components/stories_panel/stories_tree/index.js 38.73% <0%> (-1.83%) ⬇️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (-1.78%) ⬇️
lib/ui/src/modules/ui/components/layout/index.js 27.15% <0%> (-1.04%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733a5a8...845ab85. Read the comment docs.

@ndelangen
Copy link
Member

@sixmen You should now have access to the main repo, you do not have to work from your fork anymore, you can create branches and commit directly on this repo ;) 👍

@sixmen
Copy link
Member Author

sixmen commented Apr 19, 2018

I think this is not needed anymore. I'll close this.

@sixmen sixmen closed this Apr 19, 2018
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin alexandrebodin is a code owner

@alterx alterx Awaiting requested review from alterx alterx is a code owner

@danielduan danielduan Awaiting requested review from danielduan

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@jbovenschen jbovenschen Awaiting requested review from jbovenschen jbovenschen is a code owner

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg leonrodenburg is a code owner

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

@renaudtertrais renaudtertrais Awaiting requested review from renaudtertrais renaudtertrais is a code owner

@rhalff rhalff Awaiting requested review from rhalff

@saponifi3d saponifi3d Awaiting requested review from saponifi3d saponifi3d is a code owner

@theinterned theinterned Awaiting requested review from theinterned theinterned is a code owner

@usulpro usulpro Awaiting requested review from usulpro usulpro is a code owner

@z4o4z z4o4z Awaiting requested review from z4o4z z4o4z is a code owner

Assignees
No one assigned
Labels
ci: do not merge dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sixmen @storybook-safe-bot @Hypnosphi @ndelangen